Let the Deno run spawn a child, so the watch test runs - #28
Open
tamnd wants to merge 1 commit into
Open
Conversation
The progress test spawns a node process and watches the file it writes, which under Deno is run access and the command did not ask for it. So the test threw NotCapable rather than failing on an assertion, and it had never run under Deno at all: the one job that covers the watch path on that runtime was covering nothing. With --allow-run the suite is 355 passed, 0 failed, 8 ignored on deno 2.9.5, the same version CI installs, and the watch test takes 123 ms, so the child really did spawn and really did exit. Nothing else in the suite needs it, and node keeps running the same test the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27.
test:denoasked for read, write, env and ffi, and the progress testspawns a node process to watch the file it writes. That is run access,
so under Deno the test threw
NotCapable: Requires run access to "node", run again with the --allow-run flagattest/progress.test.mjs:226instead of asserting anything. It hadnever run on that runtime.
This adds
--allow-run. Locally on deno 2.9.5, the same version CIinstalls:
against the CI baseline of 354 passed, 1 failed. The watch test takes
123 ms, so the child really did spawn and really did exit rather than
being skipped some other way. No other test in the suite needs the
permission, and node runs the same file unchanged.