Update Ember.js installation guide for non-Vite users - #2476
Conversation
|
@NullVoxPopuli is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
Added note about newer ember-cli versions generating a vite project by default.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| </a> | ||
| . | ||
|
|
||
| (note that newer ember-cli versions will generate a vite project for you by default) |
There was a problem hiding this comment.
Do you mean that newer ember-cli versions (unreleased) will do this but the current one doesn't yet?
If the current one does use Vite by default, then I think we should update this guide such that it works with the default setup you get out of the box.
There was a problem hiding this comment.
Do you mean that newer ember-cli versions (unreleased) will do this but the current one doesn't yet?
it's not about version, but more what "project template" someone is using.
People have been able to use Vite for over 2 years at this point, I think (and the LTS folks, since nearly a year ago).
If the current one does use Vite by default, then I think we should update this guide such that it works with the default setup you get out of the box.
Sounds good to me, but will folks stuck on the older build system be able to find where to configure things for Tailwind 4?
There was a problem hiding this comment.
Good question, but I think we want to have the guides to be up to date with the default setups.
I know that in the normal vite cli you can pass a template, and I don't think it's feasible to document every single template setup. In other words, if you diverge from the default setup you might have to do some more work.
The overal idea should be the same everywhere:
- Install tailwindcss
- Install the dependency that hooks into the buildsystem (e.g.:
@tailwindcss/postcss) - Configure the glue code in the correct file (the hard part that diverges the most, but you as the person using a different template might actually know where this is, often better than we do)
- Import a CSS file containing at least
@import "tailwindcss";
We can always re-introduce an older (the current one) setup version if people run into issues. But I don't think we have install instructions for previous setups of other frameworks iirc, so I don't think this is going to be a big issue to be honest.
There was a problem hiding this comment.
sounds good to me! will update this for current state
There was a problem hiding this comment.
@evoactivity with the current one I meant this: https://tailwindcss.com/docs/installation/framework-guides/emberjs
There was a problem hiding this comment.
sorry, when I replied github had decided to not show me all the replies, I was answering your original question without seeing it had already been answered. Ignore me 🤭
New Ember apps are Vite-based, so the guide now follows the same shape as the other Vite framework guides: install @tailwindcss/vite, add the plugin to vite.config.mjs, import Tailwind from app/styles/app.css, and link that stylesheet directly from index.html in place of /@embroider/virtual/app.css (per emberjs/rfcs#1148) so Vite's CSS pipeline processes it. Also registers shiki's glimmer-js grammar so the .gjs sample highlights properly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Rewrite Ember.js guide for Vite
| {{page-title "MyProject"}} | ||
| name: "application.gjs", | ||
| lang: "gjs", | ||
| code: js` |
There was a problem hiding this comment.
is this the right tag, even if the language isn't js?
There was a problem hiding this comment.
Good enough I would say:
Confidence Score: 5/5The PR appears safe to merge. The prior syntax-highlighting failure is resolved because the guide now requests Reviews (3): Last reviewed commit: "Update src/app/(docs)/docs/installation/..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
Preview looks good! |
RobinMalfait
left a comment
RobinMalfait
left a comment
There was a problem hiding this comment.
Looking good, thanks!
Verified locally that it works after each step.
I did remove one sentence near the beginning that didn't feel necessary to me.
Thanks again!
5 participants
lemme know if anything needs to change / go in a different spot