Stop tracking generated app-shell skills#376
Merged
Merged
Conversation
itsprade
approved these changes
Jul 9, 2026
Contributor
Author
|
|
Contributor
Author
|
Note: CI started failing after the The commit stabilizes those tests by waiting for the live region to settle before snapshotting. |
interacsean
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
packages/core/skillsis generated output, but the source of truth lives undercatalogue/.Keeping the generated tree checked into git made normal changes noisy and easy to get wrong: catalogue edits and generated output were mixed together, generated files could drift from their source, and it was too easy to treat generated files as something to edit directly instead of regenerating from the catalogue inputs.
This PR keeps the generated skills out of git, keeps the generator output in sync with the catalogue inputs, and moves validation to the catalogue side without making
packages/coredepend on catalogue paths.Design Decision
Instead of treating generated skills as tracked source files, this change treats them as build output.
The release flow stays on the existing root
pnpm buildpath, wherecataloguealready owns skill generation. This keepspackages/corefree of any direct dependency oncataloguepaths or package-local generation hooks.To keep a guardrail in place, the catalogue now carries a small manifest-based check. The test compares the generated
packages/core/skills/**file set againstcatalogue/expected-skills-files.txt, and Turbo is configured to run localbuildbeforetestso the generated tree exists before validation runs.The generator was also made deterministic by sorting discovered inputs and normalizing the generated index tables, so catalogue changes produce stable skill output instead of order-dependent churn.
Summary
packages/core/skillsin git and ignore regenerated local outputcatalogue/ root build flow, without adding apackages/core-local generation hook