fix: resolve TDZ error in defineI18nLabels by breaking circular dependency#183
Open
fix: resolve TDZ error in defineI18nLabels by breaking circular dependency#183
Conversation
commit: |
Contributor
Author
|
/review |
Contributor
Author
|
No issue reported by AI review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a runtime TDZ (Temporal Dead Zone) error — "Cannot access before initialization" — that occurred when calling
defineI18nLabelsat module top-level in production builds (vite build). The issue did not occur in development mode.Root Cause
A circular module dependency was introduced in v0.34.0:
When Rollup linearizes this cycle for the production bundle,
defineI18nLabels(aconstdeclaration inhooks/i18n.ts) can be accessed before it is initialized, causing a TDZ error.Fix
Remove the
DefaultErrorBoundaryimport fromappshell-context.tsx, breaking the cycle. The default value is now applied inappshell.tsx— which has no path back intohooks/i18n.ts— viaprops.errorBoundary ?? <DefaultErrorBoundary />.