fix(watch): apply IDE excludes from real JSONC settings - #59
Open
younna-ai-opencode wants to merge 6 commits into
Open
fix(watch): apply IDE excludes from real JSONC settings#59younna-ai-opencode wants to merge 6 commits into
younna-ai-opencode wants to merge 6 commits into
Conversation
Strict serde_json treated real VS Code settings as empty, so tracked vendor trees stayed in the Linux watch census and tripped TooManyFolders at the capped 4097 count. Parse comments and trailing commas, record load status, and tell the truth in the degraded-watch warning.
Drop the stored sibling count so it cannot drift from patterns.len().
jsonc-parser does not treat U+FEFF as whitespace, so a BOM-prefixed settings.json stayed Unreadable and dropped every watcherExclude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live watching stayed off after IDE watcher excludes shipped. VS Code writes workspace settings as JSONC. The loader used strict JSON, so comments or a trailing comma emptied the rule set. Tracked vendor trees stayed in the Linux census and the UI still reported the capped 4097-folder warning.
This PR parses that file as JSONC, records whether it loaded, and names
files.watcherExcludein the warning. When the walk stops at the budget, the count is worded as more than the budget, not as an exact total.Continues the IDE-exclude work from #57.
Test plan
cargo test -p gitcomet-state— 779 passedcargo clippy -p gitcomet-state -- -D warnings— clean//inside a string loadsrepos/Related: #58