ci: pin GitHub Actions to commit SHAs and add pinact#89
Open
tembleking wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins GitHub Actions references to immutable commit SHAs to reduce CI supply-chain risk, and integrates pinact into the Nix dev shell + just update flow so pins can be refreshed automatically.
Changes:
- Add
pinactto the Nix dev shell and runpinact run -uduringjust update. - Update GitHub Actions workflows to use commit-SHA-pinned
uses:entries (with human-readable# vX.Y.Zcomments). - Bump the stale workflow to actions/stale v10 pinned by SHA.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
justfile |
Runs pinact run -u as part of just update to keep action pins current. |
flake.nix |
Adds pinact to the dev shell packages so just update can run it. |
.github/workflows/stale.yml |
Pins actions/stale to a specific commit SHA (v10.3.0). |
.github/workflows/pull-request-ci.yaml |
Pins all referenced actions to commit SHAs (checkout, nix installer/cache, docker, artifacts, scan). |
.github/workflows/publish.yaml |
Pins all referenced actions to commit SHAs (checkout, nix installer/cache, docker, artifacts, gh-release). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mateobur
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutable tags (@v5, @V3...) let a compromised or retagged action run arbitrary code in CI with packages:write and contents:write. Pinning to full commit SHAs removes that supply-chain vector while keeping a readable `# vX` comment for humans.
Adds `pinact` to the dev shell and wires `pinact run -u` into `just update`, so pinned actions stay current on each dependency bump instead of drifting silently.
The same run bumped several actions across majors (checkout v6, upload-artifact v7, download-artifact v8, docker setup-buildx v4 / login v4 / build-push v7, action-gh-release v3, stale v10, nix-installer v22, magic-nix-cache v14, scan-action pinned at v6.3.6). Verified none of the removed inputs/env vars are used and all current options still work. The only behavioral change is download-artifact v8 erroring on digest mismatch (a security improvement); GitHub-hosted runners satisfy the new Node 24 runtime.