Skip to content

fix: update bitkit core #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ovitrif wants to merge 2 commits into from
Closed

fix: update bitkit core #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816690c
fix: update bitkit core
ovitrif Jun 26, 2026
a985433
chore: rename changelog fragment
ovitrif Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Bitkit.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,7 @@
repositoryURL = "https://github.com/synonymdev/bitkit-core";
requirement = {
kind = exactVersion;
version = 0.1.66;
version = 0.1.75;

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Wire core LNURL invoice validation into pay flow

For LNURL-pay requests, this bump only updates the package; the app still fetches invoices through LnurlHelper.fetchLnurlInvoice (Bitkit/Utilities/Lnurl.swift:130-149) from both LnurlPayConfirm and SendQuickpay, and those call sites then pass sats: nil to sendWithTimeout, so a callback that returns a BOLT11 for a different amount is still paid at the invoice's amount. Please route these call sites through the new bitkit-core v0.1.75 validation or validate amount/metadata locally so the dependency bump actually protects LNURL-pay users.

Useful? React with 👍 / 👎.

};
};
96E20CD22CB6D91A00C24149 /* XCRemoteSwiftPackageReference "CodeScanner" */ = {
Expand Down
4 changes: 2 additions & 2 deletions Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions changelog.d/hotfix/609.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improved LNURL-pay payment handling.
Loading