feat(probe): include route fee in reports#191
Merged
Conversation
Collaborator
|
@cursor review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the mainnet Lightning “probe” E2E flow to capture and report the route fee returned by the underlying devtools probe command (currently noted as Android-only support).
Changes:
- Parse a richer probe command result (success + optional duration + optional route fee) instead of only a boolean success.
- Include
routeFeeMsatinProbeResultand render it as a new column in the generated markdown probe report. - Harden JSON fetching by erroring on successful HTTP responses with empty bodies (to avoid JSON parse failures with unclear errors).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/specs/mainnet/probe.e2e.ts |
Switches probe execution to use parsed command result and plumbs routeFeeMsat/duration into probe outcomes. |
test/helpers/probe.ts |
Adds ProbeCommandResult parsing, extends ProbeResult with routeFeeMsat, and renders the new report column. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
This seems not compatible with bitkit-andorid |
Collaborator
|
It seems good after d3a101d. Tested on master and synonymdev/bitkit-android#1052. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include route fee in reports
Currently only works with
bitkit-androidsynonymdev/bitkit-android#1052