fix: clear Play Console NFC scheme warning#1054
Draft
jvsena42 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
BROWSABLEcategory from the NFCNDEF_DISCOVEREDintent filter to clear the Google Play Console Deep Links warning "Add an ACTION_VIEW intent action attribute to the intent filter" that was raised againstBITCOIN://and nearly all other custom schemes.Description
The custom schemes (
bitcoin,bitkit,lightning,lnurl*, etc.) are declared twice: once in the deep-link filter that already hasACTION_VIEW, and once in the NFC filter that usesNDEF_DISCOVERED. Because the NFC filter also carriedBROWSABLE, Play's link crawler treated those schemes as browsable deep links missing anACTION_VIEWaction and flagged them.NFC tag dispatch matches on the action and data only and does not need
BROWSABLE, so dropping that category clears the false warning while keeping the gift-card-tap flow intact (gift cards encodebitkit://gift-<code>-<amount>, which the NFC filter still matches via itsbitkitscheme). The deep-linkACTION_VIEWfilter and the autoVerify App Links filter are unchanged.This addresses only the custom-scheme warning. The separate "domain failed validation" error for
https://www.bitkit.to/treasure-huntis a server-side Digital Asset Links issue (the liveassetlinks.jsonlists the wrong package) and is tracked in synonymdev/synonym-website#245.Preview
QA Notes
Manual Tests
regression:Tap an NFC gift card → Gift sheet opens and the claim proceeds as before.regression:Open a custom-scheme link (bitcoin:/lightning:/lnurl/bitkit://) from another app → Bitkit opens and routes to the correct flow.Automated Checks
just compileand detekt pass locally; standard compile/unit/detekt checks run by the PR bot.