fix(sdk): TextArea is highlighted; empty required strings trigger an error#70
fix(sdk): TextArea is highlighted; empty required strings trigger an error#70szymon-t-sc wants to merge 1 commit into
Conversation
| onChange={onChange} | ||
| onBlur={onBlur} | ||
| size="medium" | ||
| error={errors.length > 0} |
| if (trimmed === '') { | ||
| // eslint-disable-next-line unicorn/no-useless-undefined | ||
| handleChange(path, undefined); | ||
| } else if (isNumberInput) { |
There was a problem hiding this comment.
'' is saved as regular string.
We set undefined earlier to remove that property, allowing the validator to mark the field as required. This behavior was not implemented in TextArea, where '' was set instead, so the required validation error was not triggered.
This change unifies the behavior between the two fields.
Why use this approach instead of adding undefined to textarea? This is primarily a validator issue and should be fixed there. Removing the property works for new props, but if we set defaultProperties with empty '' (which is fine) validation will not work correctly because it assigns undefined onBlur in the control.
Having clear default values like '', which match the expected type, is preferable to relying on control behavior.
1 participant
No description provided.