Add configurable QoS for the managed Syncthing process - #294
Draft
robios wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The wrapper currently launches Syncthing with background QoS unconditionally.
On systems with large folders, macOS background scheduling can make full scans
substantially slower. Normal and Utility allow users to trade energy impact for
scan performance without changing Syncthing's own configuration.
Closes #293
Testing
make debugOKboth avoid the severe slowdown observed with Background
Compatibility
If the preference has never been set, or contains an unknown value, the app
continues to use Background. This preserves the behavior of existing
installations.
Draft status
This is ready for design feedback. Additional controlled scan timings and
longer-running Utility usage can be added before marking the PR ready for
review.