Fix Subprocess.run API updates#775
Conversation
|
It looks like we'll also need to drop the I'm guessing this won't be an issue since we document Swift 6.2 as being the minimum required version in the README anyway. |
|
This is causing the swift-android-examples to fail to build with the errors: |
|
An alternative solution could be to pin |
…ly update to 1.0 once it is released
|
I’ll have to double check if we need 6.1 in some adopters… thank you for the pr! |
madsodgaard
left a comment
There was a problem hiding this comment.
We also just hit this.
Change looks fine to me. If we can drop 6.1 👍
|
We technically can't drop 6.1 until 6.4 is out... We're supporting some projects which follow the usual 3-versions support cycle, so this is jumping ahead a little bit... I'm thinking maybe we limit the range for now, and then later bump to 0.5+ as well as settle on the 1.0 eventually 🤔 |
|
Thank you, for now let's support 6.1 but I agree this is the right change in a few months or maybe sooner, I just need to phase the 6.1 usage out a bit more carefully. Thanks @marcprux ! |
|
Doing this for now: #777 |
Fixes the API breakage introduced in swift-subprocess 0.5 by swiftlang/swift-subprocess#233.