Skip to content

[Crash] Avoid iOS 16 URL parsing crash in stringWithUserAndPasswordStripped #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
o-nnerb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Crash] Avoid iOS 16 URL parsing crash in stringWithUserAndPasswordStripped #916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/AsyncHTTPClient/TracingSupport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,12 @@ internal struct HTTPRequestCancellationError: Error {}
extension URL {
/// Returns the absolute string of `url` with any embedded credentials (username and password) removed to avoid logging secrets.
fileprivate var stringWithUserAndPasswordStripped: String? {
if #available(macOS 13.0, iOS 16.0, tvOS 16.0, watchOS 9.0, *) {
// NOTE: Deliberately gated on iOS 17 (not the iOS 16 the percent-encoded `user()`/`password()`
// APIs were introduced in). On iOS 16, calling these APIs can crash inside the shared URL
// component parsing code (the trap surfaces in `URL.host(percentEncoded:)` even though `host`
// is never called here) - see https://forums.swift.org/t/70452. The legacy, non-percent-encoded
// `user`/`password` properties below don't hit that bug and are used as a workaround on iOS 16.
if #available(macOS 14.0, iOS 17.0, tvOS 17.0, watchOS 10.0, *) {
guard self.user() != nil || self.password() != nil else {
return self.absoluteString
}
Expand Down