refactor(oauth2-redirect): parse query with URLSearchParams#10945
Open
MysteryBlokHed wants to merge 1 commit into
Open
refactor(oauth2-redirect): parse query with URLSearchParams#10945MysteryBlokHed wants to merge 1 commit into
URLSearchParams#10945MysteryBlokHed wants to merge 1 commit into
Conversation
Replaces the query parameter parser that used splitting and concatenation with `URLSearchParams`. This makes the parsing more correct and avoids issues if JSON-significant characters appear in the query params. I didn't touch the files in `dist/` because I'm not fully sure how they're generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the query parameter parser that used splitting and concatenation with
URLSearchParams. This makes the parsing more correct and avoids issues if JSON-significant characters appear in the query params.I didn't touch the files in
dist/because I'm not fully sure how they're generated.Technically this is not strictly a refactor since edge cases are now handled correctly, but the behaviour is the same on expected input.
Motivation and Context
The old parser built a fake JSON object literal from the query string and broke on any value containing JSON-significant characters (like
",\,{,}). The standardURLSearchParamsAPI is reliable and preserves the existing output shape (a plain object passed through as the token).How Has This Been Tested?
Verified parsing equivalence in Node (
Object.fromEntries(new URLSearchParams(...))forcode/token/errorquery and hash forms, empty input, anda=b=c)Screenshots (if appropriate):
N/A
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests