Update magic-string to 1.1.0 and @eksml/xml to 0.2.0 - #10
Merged
Conversation
Both are breaking bumps (magic-string 0.30 to 1.x, eksml 0.1 to 0.2), but the API surface we use is unchanged. Verified with typecheck and the full unit suite (123 passed), plus the e2e targets that render the shared eksml output. Also includes two small fixes needed to keep the branch green: - Add isEmbedded to BASE_CTX in codegen.test.ts, which was a pre-existing typecheck failure on main. - Add test-results and playwright-report to .prettierignore so prettier stops flagging Playwright artifacts.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates two runtime dependencies of
@svg-jar/plugin:magic-string^0.30.17^1.1.0@eksml/xml^0.1.2^0.2.0Both are breaking version bumps, but the API surface the plugin uses is unchanged:
magic-stringis only used inrender-chunk.ts(new MagicString,.overwrite,.toString,.generateMap), all stable across 1.x.@eksml/xml./losslessand./writerentry points and their signatures (lossless,write,LosslessEntry) are unchanged between 0.1.2 and 0.2.0.Verification
typecheckcleantest:unit123 passedlintcleanIncidental fixes needed to keep the branch green
isEmbeddedtoBASE_CTXincodegen.test.ts, a pre-existing typecheck failure onmain.test-results/andplaywright-report/to.prettierignoreso prettier stops flagging Playwright artifacts.