Skip to content

Enhance default parsing of bind variables for SQL queries #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garricko wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Enhance default parsing of bind variables for SQL queries #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
741ff74
Use smarter parsing of bind variables by default to avoid having to e…
garricko Jul 10, 2026
e152ede
Downgrade Derby to 10.15.2.0 for Java 17 compatibility
Copilot Aug 20, 2026
6be402e
Fix review comments: add dollar-quoting/bracket identifier support, d…
Copilot Aug 20, 2026
3ce3f91
Add tests for dollar-quoting and SQL Server bracket identifier smart …
Copilot Aug 20, 2026
cd1319c
Merge branch 'master' into smart-bind-parsing
garricko Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,13 +269,13 @@
<dependency>
<groupId>org.apache.derby</groupId>
<artifactId>derby</artifactId>
<version>10.17.1.0</version>
<version>10.15.2.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.derby</groupId>
<artifactId>derbytools</artifactId>
<version>10.16.1.1</version>
<version>10.15.2.0</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
35 changes: 25 additions & 10 deletions src/main/java/com/github/susom/database/Database.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,11 @@ public interface Database extends Supplier<Database> {
* Note this call does not actually execute the SQL.
*
* @param sql the SQL to execute, optionally containing indexed ("?") or
* named (":foo") parameters. To include the characters '?' or ':'
* in the SQL you must escape them with two ("??" or "::"). You
* named (":foo") parameters. By default, "smart" parsing is used:
* '?' and ':' characters inside string literals, quoted identifiers,
* and comments are treated as regular SQL text and do not need to be
* escaped. When {@link Options#useSmartSqlParameterParsing()} returns {@code false} (legacy mode), literal '?' or ':'
* characters must be escaped by doubling them ("??" or "::"). You
* MUST be careful not to pass untrusted strings in as SQL, since
* this will be executed in the database.
* @return an interface for further manipulating the statement; never null
Expand All @@ -54,8 +57,11 @@ public interface Database extends Supplier<Database> {
* Note this call does not actually execute the SQL.
*
* @param sql the SQL to execute, optionally containing indexed ("?") or
* named (":foo") parameters. To include the characters '?' or ':'
* in the SQL you must escape them with two ("??" or "::"). You
* named (":foo") parameters. By default, "smart" parsing is used:
* '?' and ':' characters inside string literals, quoted identifiers,
* and comments are treated as regular SQL text and do not need to be
* escaped. When {@link Options#useSmartSqlParameterParsing()} returns {@code false} (legacy mode), literal '?' or ':'
* characters must be escaped by doubling them ("??" or "::"). You
* MUST be careful not to pass untrusted strings in as SQL, since
* this will be executed in the database.
* @return an interface for further manipulating the statement; never null
Expand All @@ -73,8 +79,11 @@ public interface Database extends Supplier<Database> {
* Note this call does not actually execute the SQL.
*
* @param sql the SQL to execute, optionally containing indexed ("?") or
* named (":foo") parameters. To include the characters '?' or ':'
* in the SQL you must escape them with two ("??" or "::"). You
* named (":foo") parameters. By default, "smart" parsing is used:
* '?' and ':' characters inside string literals, quoted identifiers,
* and comments are treated as regular SQL text and do not need to be
* escaped. When {@link Options#useSmartSqlParameterParsing()} returns {@code false} (legacy mode), literal '?' or ':'
* characters must be escaped by doubling them ("??" or "::"). You
* MUST be careful not to pass untrusted strings in as SQL, since
* this will be executed in the database.
* @return an interface for further manipulating the statement; never null
Expand All @@ -92,8 +101,11 @@ public interface Database extends Supplier<Database> {
* Note this call does not actually execute the SQL.
*
* @param sql the SQL to execute, optionally containing indexed ("?") or
* named (":foo") parameters. To include the characters '?' or ':'
* in the SQL you must escape them with two ("??" or "::"). You
* named (":foo") parameters. By default, "smart" parsing is used:
* '?' and ':' characters inside string literals, quoted identifiers,
* and comments are treated as regular SQL text and do not need to be
* escaped. When {@link Options#useSmartSqlParameterParsing()} returns {@code false} (legacy mode), literal '?' or ':'
* characters must be escaped by doubling them ("??" or "::"). You
* MUST be careful not to pass untrusted strings in as SQL, since
* this will be executed in the database.
* @return an interface for further manipulating the statement; never null
Expand All @@ -111,8 +123,11 @@ public interface Database extends Supplier<Database> {
* Note this call does not actually execute the SQL.
*
* @param sql the SQL to execute, optionally containing indexed ("?") or
* named (":foo") parameters. To include the characters '?' or ':'
* in the SQL you must escape them with two ("??" or "::"). You
* named (":foo") parameters. By default, "smart" parsing is used:
* '?' and ':' characters inside string literals, quoted identifiers,
* and comments are treated as regular SQL text and do not need to be
* escaped. When {@link Options#useSmartSqlParameterParsing()} returns {@code false} (legacy mode), literal '?' or ':'
* characters must be escaped by doubling them ("??" or "::"). You
* MUST be careful not to pass untrusted strings in as SQL, since
* this will be executed in the database.
* @return an interface for further manipulating the statement; never null
Expand Down
Loading
Loading