fix(openai-sdk-python): support supermemory 3.50 type and API renames#1295
Open
shitcodebykaushik wants to merge 1 commit into
Open
Conversation
Fresh pip installs pull supermemory 3.50, which renamed MemoryAddResponse and MemoryGetResponse and moved document creation to client.add(). The package failed to import and memory writes used a removed API surface. Migrate tools and middleware to AddResponse/DocumentGetResponse and client.add(), pin supermemory>=3.50.0 (Python 3.9+), and add import compatibility regression tests. Fixes supermemoryai#1235
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supermemory-openai-sdkto the supermemory 3.50 client API so a freshpip install supermemory-openai-sdkno longer fails on import.MemoryAddResponse/MemoryGetResponsewithAddResponse/DocumentGetResponse.client.add(...)instead of the removedclient.memories.add(...)(tools + middleware).supermemory>=3.50.0, raiserequires-pythonto>=3.9(required by supermemory 3.50), refreshuv.lock, and bump package version to1.0.5.client.addcall sites.Test plan
pip install -e .against supermemory 3.50.0 —import supermemory_openaisucceedspytest tests/test_import_compat.py— 4 passedsupermemory-openai-sdk1.0.5 to PyPI after mergeFixes #1235