fix(cartesia-sdk): avoid retrying wrapped agent#1275
Open
GautamSharma99 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Cartesia wrapper previously enclosed memory preparation and the entire
wrapped-agent stream in one broad
try/except.If the wrapped agent failed—even after yielding output—the exception handler
invoked it again from the beginning. This could duplicate spoken output, tool
calls, messages, payments, or other non-idempotent actions.
This PR:
Behavioral change
Before:
After:
Tests
Added regression coverage for:
Validation completed:
py.typedmarkerThe existing
agent.pyfile is not fully Black-formatted onmain; this PRavoids unrelated whole-file formatting changes. The repository-wide Bun suite
also retains unrelated existing failures.