fix(web): scope daily brief cache by account#1274
Open
GautamSharma99 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily space highlights were cached only by project ID. Since default project tags
can repeat across accounts, another user signing in through the same browser
could receive the previous user’s cached highlights and suggested questions.
This PR:
space-highlights-v1cache namespaceand organization reset
Privacy impact
Cached daily briefs can no longer be reused across accounts that share project
tags such as
sm_project_default.Previously cached entries are isolated by moving to the
space-highlights-v2namespace and deleting the legacy cache after authentication resolves.
Tests
Added regression coverage for:
Validation completed:
The repository-wide suite currently reports unrelated existing failures in MCP
OAuth tests, Tools tests, and memory-graph rendering tests. Repository-wide type
checking also reports existing errors outside the changed files.