fix(web): validate proxy sessions#1272
Open
GautamSharma99 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The web proxy previously treated the presence of a Better Auth session cookie as
proof of authentication. Since
getSessionCookie()only extracts the cookievalue, forged or expired cookies could pass the proxy and access protected
internal API routes.
This PR:
401for API routes/loginTests
Added proxy-level regression coverage for:
Focused tests and Biome checks pass.
The repository-wide suite currently reports unrelated pre-existing failures in
MCP network tests, Tools tests, and memory-graph render tests. Repository-wide
type checking also reports existing errors outside the changed files.