fix: env to control tenant config visibility#989
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a configuration toggle to control whether admin tenant endpoints return decrypted, sensitive tenant configuration values.
Changes:
- Introduces
ADMIN_RETURN_TENANT_SENSITIVE_DATAconfig flag (defaulting to enabled unless explicitly set tofalse). - Gates sensitive fields (
anonKey, DB URLs,jwtSecret,jwks,serviceKey) in adminGET /tenantsandGET /tenants/:tenantIdresponses behind the new flag. - Documents the new environment variable in
.env.sample.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/http/routes/admin/tenants.ts |
Conditionally includes decrypted tenant secrets in admin GET responses based on config flag. |
src/config.ts |
Adds adminReturnTenantSensitiveData to runtime config, sourced from env. |
.env.sample |
Documents ADMIN_RETURN_TENANT_SENSITIVE_DATA and its effect on tenant admin endpoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Coverage Report for CI Build 26504259252Coverage remained the same at 75.15%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
ferhatelmas
approved these changes
Apr 7, 2026
fenos
force-pushed
the
tenant/env-for-tenant-sensible-info
branch
from
6fadb26 to
c6ed793
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fenos
force-pushed
the
tenant/env-for-tenant-sensible-info
branch
from
8e9c715 to
a90822f
Compare
fenos
force-pushed
the
tenant/env-for-tenant-sensible-info
branch
from
a90822f to
e7c2e09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Improvement
What is the current behavior?
What is the new behavior?