fix(ci): clean up dangling EBS volumes left by Packer builds#2165
Open
jfreeland wants to merge 1 commit into
Open
fix(ci): clean up dangling EBS volumes left by Packer builds#2165jfreeland wants to merge 1 commit into
jfreeland wants to merge 1 commit into
Conversation
darora
approved these changes
May 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Packer's stage-1
amazon-ebssurrogatebuilds detach temporary volumes before terminating the build instance, leaving them inavailablestate and accumulating cost. This PR tags those volumes withpackerExecutionIdduring the Packer run, then sweeps any matching unattached volumes in each workflow's cleanup hooks.While doing this, I noticed
ami-release-nix-single.ymlwas running its cleanup with leftoverPROD_AWS_ROLEcredentials from the earlier staging→prod rotation, meaning the existing instance-termination cleanup was silently no-op'ing against the wrong account. Added a dedicatedDEV_AWS_ROLEre-auth step before cleanup to fix this.