fix(cli): chunk storage delete requests to respect API cap (#1814)#5629
fix(cli): chunk storage delete requests to respect API cap (#1814)#5629avallete wants to merge 3 commits into
Conversation
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@a18a226e2198616deca94a7a954ac869f6f8841cPreview package for commit |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a18a226e21
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if registry == "ghcr.io" && strings.HasPrefix(imageName, "supabase/logflare:") { | ||
| return imageName |
There was a problem hiding this comment.
Use Docker Hub auth when bypassing the GHCR mirror
When INTERNAL_IMAGE_REGISTRY=ghcr.io, this branch pulls supabase/logflare:* from Docker Hub, but DockerImagePull and the compose pull wrapper still attach utils.GetRegistryAuth(), which is loaded for GetRegistry() (ghcr.io). Docker's image-create API treats X-Registry-Auth as the auth config for the registry being pulled (https://docs.docker.com/reference/api/engine/version/v1.51/#tag/Image/operation/ImageCreate), so users who have GHCR credentials configured can send those credentials on the Docker Hub Logflare pull and hit an auth failure for an otherwise public image. This special case needs to also select Docker Hub/empty auth, or skip the registry auth for this image.
Useful? React with 👍 / 👎.
Summary
storage rmnow splits delete calls intoDELETE_OBJECTS_LIMITbatches instead of sending every prefix in one request.Testing