fix: map concurrent MFA verify races to 4xx instead of 500 - #2791
Open
hsusul wants to merge 1 commit into
Open
Conversation
Lock the session before inserting AMR claims, and translate FK violations/deadlocks from peer aal1 invalidation into conflict-style client errors so same-user concurrent verifies stop looking like internal failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /factors/{id}/verifyfor the same user could return500 unexpected_failure(FK23503/ deadlock40P01) when one verify'sInvalidateSessionsWithAALLessThandeleted another in-flight aal1 session mid-AddClaimToSession.FindSessionByID(..., true)before inserting AMR claims, then reload associations so AAL calculation still sees the new claim.403 session_not_found/409 conflict) instead of internal failures.Test plan
go test ./internal/api -run TestMapMFASessionConflictErrorgo test ./internal/api -run 'TestMFA$'(includes new missing-session + concurrent verify regression tests)