🐛(backend) fix scoped full-text search - #2590
Conversation
Document-scoped indexer searches attempted to call a queryset method on a Document instance and failed before reaching Find. Resolve the path from the queryset and cover the scoped request. Signed-off-by: fch-aa <21101725+fch-aa@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review. WalkthroughThe backend now retrieves the scoped document path through a queryset projection before running the indexer search. A regression test verifies successful document-scoped searches and the path passed to the indexer. The changelog records the fix. Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to Scoped searches now resolve the document path before querying, but access control for the parent document and descendants should be explicitly confirmed to prevent unauthorized search results; the PR is otherwise mergeable with owner awareness. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@fch-aa thanks for your PR! |
Fixes #2589
Purpose
Scoped full-text searches fail before reaching the search indexer, preventing
users from searching within a document and its subdocuments.
Proposal
The full backend suite passes with 2,214 tests passed and 1 skipped. Ruff,
Pylint, and gitlint also pass.
External contributions
General requirements
CI requirements
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)AI requirements