chore(deps): upgrade major npm packages (Next 16, recharts 3, etc.) - #3
Open
tembo[bot] wants to merge 1 commit into
Open
chore(deps): upgrade major npm packages (Next 16, recharts 3, etc.)#3tembo[bot] wants to merge 1 commit into
tembo[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Alan <45767683+stylessh@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Requesting review from @stylessh who has experience with the following files modified in this PR:
|
Owner
|
i post a new comment from trylle |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the major npm package versions in the
interactionsrepo and fixes the breaking changes each one introduced. Build, type-check, and lint all pass, and the recharts-driven analytics chart was verified rendering in a real browser.Major version bumps
nexteslint-config-nextrecharts@vercel/analyticslucide-reactsugar-hightailwind-merge@types/nodetypescriptBreaking changes handled
next lintcommand. Thelintscript now callseslint .directly, and the legacy.eslintrc.jsonwas migrated to a flateslint.config.mjs(required by the modern ESLint pipeline) usingeslint-config-next's native flat config export.tsconfig.jsonchanges during build (jsx: preserve→react-jsx, and adding.next/dev/types). Also removed the now-deprecateddownlevelIterationflag (TypeScript 6 errors on it; it was a no-op at the project'sES2017target).components/ui/chart.tsxto the recharts-3 typing (DefaultTooltipContentProps/DefaultLegendContentProps,TooltipValueType), used a stable list key, and guarded the now-optionalitem.payload. The project's custom color tokens and styling were preserved.eslint-plugin-react-hooksv7 with React Compiler-aware rules. Fixed the newly-flagged issues:shortcut-button/components/button.tsx: hoisted thehandleClickuseCallbackaboveuseHotkeys(was used before declaration) and added it to the hotkey deps.content-timeline/page.tsx: replaced derivedactiveCheckpointstate + effect (setStatein effect) with auseMemocomputed during render.Notably not upgraded
^9.39.4). ESLint 10 is not yet viable: the plugins bundled byeslint-config-next(eslint-plugin-react,-import,-jsx-a11y) cap their peer range at ESLint 9, and ESLint 10 crasheseslint-plugin-reactat runtime (contextOrFilename.getFilename is not a function). Bumped to the latest 9.x instead.Verification
pnpm build— passes (all 14 routes prerender)pnpm exec tsc --noEmit— passespnpm lint— passes, 0 errors (2 pre-existingexhaustive-depswarnings left untouched as they predate this change and are behavior-sensitive)Note for reviewer
@types/nodewas bumped to the latest major (25) per the "upgrade majors" request, while the sandbox runs Node 22. This is harmless here but you may prefer to pin it to^22to match the runtime.