fix,test: added test cases and added connecting in RedisDataSrc#setup#7
Merged
fix,test: added test cases and added connecting in RedisDataSrc#setup#7
Conversation
sttk
force-pushed
the
test/add_test_cases
branch
from
4d5f1df to
d64c223
Compare
sttk
changed the title
sttk
force-pushed
the
test/add_test_cases
branch
from
03b4ff6 to
1687116
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test cases and increase coverage.
By these tests, I found the necessity to connect in
RedisDataSrc#setupand the unnecessity of theRedisDataSrcconstructor which takes onlyClientResourcesas the parameter.