Skip to content

Update table styling for balances and sources commands - #228

Open
selinafeng-stripe wants to merge 3 commits into
mainfrom
selinafeng/balances-table-formatting
Open

Update table styling for balances and sources commands#228
selinafeng-stripe wants to merge 3 commits into
mainfrom
selinafeng/balances-table-formatting

Conversation

@selinafeng-stripe

Copy link
Copy Markdown
Contributor
  • Adds an Account name column to the balances list table view
  • Slightly adjusts max column widths for the Name in the sources list table view to better handle account names that can be quite long
image image

@selinafeng-stripe
selinafeng-stripe requested a review from a team as a code owner August 5, 2026 19:47

@mangeli-stripe mangeli-stripe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, thoughts?

const idWidth = sourceIdWidth(balances);
const accountNameWidth = nameWidth(balances);
const headerRow = [
formatCell('Account name', accountNameWidth),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion to be consisted with the "Source ID" column?

Suggested change
formatCell('Account name', accountNameWidth),
formatCell('Source name', accountNameWidth),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants