Update sample project assets - #3360
Conversation
|
I believe this was introduced by #3270 where asset references now include a prefix with the path to the package they originate from. |
Kryptos-FR
left a comment
Kryptos-FR
left a comment
There was a problem hiding this comment.
A few remarks and questions. Did you make sure to run every single sample?
| Modifiers: {} | ||
| ~SourceHashes: | ||
| a3fd31595ff0552e77b220f459eeaf7f~../../Resources/Models/nav_test.obj: 8e853318ac2ce938655b593a4b50a601 | ||
| 7fe7324c44786f3c5cdd2bffe9b77e9a~../../../Resources/Models/nav_test.obj: 07acf28a20706c789e37ca5971707b86 |
There was a problem hiding this comment.
This one is a bit surprising. It seems correct but I wonder how it worked before.
| <Project Path="Audio/SimpleAudio/SimpleAudio.Windows/SimpleAudio.Windows.csproj"> | ||
| <Deploy Solution="Debug|*" /> | ||
| <Deploy Solution="Release|*" /> | ||
| <Deploy /> |
There was a problem hiding this comment.
Better remove the empty markups to clean the solution file.
| e0beca31326612052db3b4c09aa5d3cb: !CSharpBeginner.Code.LerpDemo,CSharpBeginner.Game | ||
| Id: f02fdc23-0f1f-48ab-a3fd-638768d10efa | ||
| AnimationTime: 3.0 | ||
| AnimationTimer: 5.0 |
There was a problem hiding this comment.
That's a different value, but also a differently named property. Better check whether it is still correct.
| - f6f2a96e-6b05-4119-bba1-87c1fa5c8fdf:Scenes/06_SceneLoading/Completed-SceneA | ||
| - f86f50d4-4d14-4445-b352-3167249469f8:Scenes/08_Audio/Start-Audio | ||
| - fb432089-cd62-4e51-976a-38727de1fd50:Scenes/03_Raycasting/Completed-Raycasting | ||
| - 142e5ceb-04a0-41e2-845d-b3d177a4700e:/CSharpIntermediate.Game/Scenes/09_FirstPersonCamera/Start-FirstPersonCamera |
There was a problem hiding this comment.
This seems correct. However, other .sdpkg in samples which also have "root assets" weren't upgraded. For example JumpyJet or UIElementLink. Better double-check.
|
@xen2 this PR made me realize that we don't have CI jobs for the samples. |
2 participants
PR Details
This pull request updates the sample projects with reimported assets.
Related Issue
I was preparing to do other pull requests related to the sample projects, and the Game Studio prompted me to reimport a bunch of assets. Apparently, their data format has changed a bit since creation.
Types of changes
Checklist