chore: deprecate in favor of the built-in substreams sink commands - #133
Draft
GabrielCartier wants to merge 1 commit into
Draft
chore: deprecate in favor of the built-in substreams sink commands#133GabrielCartier wants to merge 1 commit into
GabrielCartier wants to merge 1 commit into
Conversation
The SQL sink was folded into the substreams CLI (streamingfast/substreams#830) and ships in v1.20.2 as `substreams sink postgres` / `substreams sink clickhouse`. Add a deprecation banner with the command mapping and a pointer to the upstream migration guide, plus a CHANGELOG entry. Databases are compatible in place, so the note leads with that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Marks this repo deprecated. The SQL sink was folded into the main
substreamsCLI in streamingfast/substreams#830 and shipped in v1.20.2 assubstreams sink postgres/substreams sink clickhouse.Unreleased→Deprecatedentry.Why lead with database compatibility
The first question an operator asks is whether they have to rebuild. They don't — cursor tables and schemas are unchanged, so the CLI resumes from the stored cursor against the same DSN. The banner says that before the command table.
Open questions for reviewers