fix: Normalize regex format - #188
Merged
Merged
Conversation
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
Member
|
These two regex tests are not the same. The original is omitting |
Contributor
Author
Uh oh Hmm, looks like it's missing four, in fact: I, L, O, and U. Which makes sense now that I think about it because it is base32... But there's 26 letters in the alphabet, and 10 numbers... So, four letters need to be dropped or else the math wouldn't math. :O Thanks for noticing this lol |
Dadadah
reviewed
Aug 20, 2026
Pecacheu
force-pushed
the
fix/regex
branch
2 times, most recently
from
August 20, 2026 04:51
634bcb7 to
ab0d830
Compare
Signed-off-by: Pecacheu <3608878+Pecacheu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches the ULID regex format with what for-web uses because I'm pedantic like that and y'all need to use RegEx properly (I need to de-duplicate some of the regex that does the same thing as these strings in for-web too later)