Skip to content

Update PoE2 to 0.23.1 - #4

Open
jamesboswell wants to merge 1 commit into
stevschmid:masterfrom
jamesboswell:master
Open

jamesboswell wants to merge 1 commit into
stevschmid:masterfrom
jamesboswell:master

Conversation

@jamesboswell

Copy link
Copy Markdown

Bump the PathOfBuilding-PoE2 submodule from v0.15.0 (3e1b71c9) to
v0.23.1 (7d6f530c), spanning 416 upstream commits.

Update canary passes against master, beta and dev. Built and packaged
the PoE2 DMG locally; the ad-hoc signature verifies and the bundle
reports 0.23.1

  Bump the PathOfBuilding-PoE2 submodule from v0.15.0 (3e1b71c9) to
  v0.23.1 (7d6f530c), spanning 416 upstream commits.

  Update canary passes against master, beta and dev. Built and packaged
  the PoE2 DMG locally; the ad-hoc signature verifies and the bundle
  reports 0.23.1
@stevschmid

Copy link
Copy Markdown
Owner

What is the reason for the bump? Does the in-app updater not correctly update to this version?

@jamesboswell

Copy link
Copy Markdown
Author

It does update, however from my experience users encounter the following.

  1. It's somewhat slow to update, 1-3 minutes. At present the 0.15.0 client has to download and patch 477 changes. This will be closer to 550+ when upstream dev merges into mainline. The backlog will only grow.
  2. 5 times via unscientific testing, I've run into download/patching seemingly stalling out taking well over 3 minutes and at least once stopped responding requiring a pkill.
  3. If you've ever previously installed and updated the client will immediately try to open last build file. Assuming the build file is newer than 0.15.0 this can throw immediate errors to user such as
    The build you are trying to load uses an unrecognised version of the passive skill tree. You may need to update the program before loading this build.
    Not super friendly, especially if you've gone offline and just want to theory craft. You're stuck.
  4. Small nit - the Path of Building - PoE2 >> About Path of Building - PoE2 menu still reports version as 0.15.0 regardless of updates.

Fully understand not trying to respond to every single upstream PoB release. I would suggest occasionally bumping version is good practice to ensure compatibility, functional and security fixes are applied to released dmg and a good experience for users.

Appreciate you considering this PR and the amazing work bringing PoB to Mac. GG to you and may the RNG be ever in your favor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants