Skip to content

feat(telemetry): log and report lock-acquisition contention at info #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swarit-stepsecurity wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(telemetry): log and report lock-acquisition contention at info #152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efbd43b
feat(telemetry): log and report lock-acquisition contention at info l…
swarit-stepsecurity Jun 25, 2026
1abf3c0
fix(telemetry): don't assume lock failure means contention
swarit-stepsecurity Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion internal/telemetry/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,16 @@ func Run(exec executor.Executor, log *progress.Logger, cfg *cli.Config) (err err
// Acquire lock
lk, err := lock.Acquire(exec)
if err != nil {
log.Debug("lock acquisition failed: %v", err)
// Lock acquisition failed — usually another instance already holds it,
// but it can also be a permission/IO error creating the lock file; the
// underlying err carries the specific cause (including the contention
// message when that's it). Surface at info level (not Debug) so it's
// visible in agent.log, and report the failed run right here — don't
// wait for the deferred handler — so the backend records the failure.
// reportFailedOnce is idempotent, so the deferred handler that also
// fires on the error return is a no-op.
log.Progress("Lock acquisition failed (PID %d): %v — exiting", os.Getpid(), err)
reportFailedOnce(fmt.Sprintf("lock acquisition failed: %v", err))
return fmt.Errorf("acquiring lock: %w", err)
}
log.Debug("lock acquired (pid=%d)", os.Getpid())
Expand Down
Loading