Correct stale network values, Horizon retention default, and ZK primitive references#2619
Merged
ElliotFriend merged 2 commits intoJul 16, 2026
Conversation
…erences - Horizon: HISTORY_RETENTION_COUNT defaults to 0 (retain everything), not 518400 — the 30-day window must be set explicitly (verified in stellar-horizon v27.0.0 internal/flags.go) - Network limits: testnet operations per ledger is 200, and smart contract transactions per ledger is 2,000 on all networks (verified live via Horizon and `stellar network settings`); added as-of dates and links to Lab's live Network Limits view - P25 release notes: BN254 host functions are CAP-74, not CAP-79 (muxed strkey, a P26 CAP) - Poseidon: CAP-75 exposes `poseidon_permutation` / `poseidon2_permutation` permutation primitives, not complete hash functions; corrected zk.mdx and privacy.mdx and linked the rs-soroban-poseidon SDK for ready-made hashing Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects stale Horizon retention guidance, network limits, and ZK primitive references.
Changes:
- Clarifies Horizon’s default unlimited retention behavior.
- Updates dated network capacity values and live-source links.
- Corrects BN254 CAP links and Poseidon permutation terminology.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
docs/networks/software-versions.mdx |
Corrects BN254 CAP links. |
docs/networks/README.mdx |
Updates network capacity table. |
docs/learn/glossary.mdx |
Updates network capacity definition. |
docs/learn/fundamentals/fees-resource-limits-metering.mdx |
Updates ledger-limit guidance. |
docs/data/apis/horizon/admin-guide/ingestion.mdx |
Corrects Horizon retention default. |
docs/data/apis/horizon/admin-guide/configuring.mdx |
Clarifies explicit retention configuration. |
docs/build/apps/zk.mdx |
Distinguishes permutations from hashes. |
docs/build/apps/privacy.mdx |
Corrects Poseidon primitive terminology. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview is available here: |
ElliotFriend
changed the title
- Relabel P25 release-notes CAP-75 entries as permutation primitives - Note the SDK's hazmat-crypto feature gate for Poseidon functions - Qualify the fees page ledger limits as Mainnet values - Complete the glossary Network capacity sentence Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Preview is available here: |
briwylde08
approved these changes
Jul 16, 2026
This was referenced Jul 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch quick-fix for three Raven-reported stale-value issues. Every value below was re-verified against live networks or upstream source before editing.
Changes
Horizon retention default (#2599)
HISTORY_RETENTION_COUNTdefaults to 0 (retain all history, never purge), not 518400 — verified instellar/stellar-horizonv27.0.0internal/flags.go. The docs claimed the 30-day window was "default set by Horizon," which meant operators who never set the flag would accumulate unbounded storage while believing they had a 30-day sliding window.docs/data/apis/horizon/admin-guide/ingestion.mdx— states the real default and that the 30-day recommendation must be set explicitlydocs/data/apis/horizon/admin-guide/configuring.mdx— same correction in the Ingestion Role Instance section (theHISTORY_RETENTION_COUNTparameter reference further down the page was already correct)Network limit tables (#2612)
Verified live today via Horizon
/ledgersandstellar network settings:max_tx_set_size)contract_execution_lanes.ledger_max_tx_count)Updated
docs/networks/README.mdx(comparison table),docs/learn/fundamentals/fees-resource-limits-metering.mdx, anddocs/learn/glossary.mdx(Network capacity entry). Since these values change by validator vote, each spot now carries an as-of date and a link to Stellar Lab's live Network Limits view, so the next drift is at least self-evidently dated.BN254 CAP link + Poseidon hash-vs-permutation (#2614)
docs/networks/software-versions.mdxlinked "BN254 Elliptic Curve Operations" to CAP-79 (muxed address strkey conversions, a P26 CAP). Corrected to CAP-74, matching the linkzk.mdxalready had.poseidon_permutation/poseidon2_permutationpermutation primitives, not complete hash functions (see CAP-0075's "Permutation Primitives vs. Hash Functions" section).docs/build/apps/zk.mdxlisted nonexistentposeidon/poseidon2host functions that "compute the Poseidon hash," anddocs/build/apps/privacy.mdxrepeated the same conflation. Both corrected, with a pointer to rs-soroban-poseidon for ready-made hash functions built on the primitives.Not included: the P27-Mainnet section for
software-versions.mdx(#2574) — the ~12 recommended versions there need confirmation with release owners first, so it's deliberately left out of this batch.Closes #2599
Closes #2612
Closes #2614
🤖 Generated with Claude Code