Move Docker image distribution to its own repo#2616
Open
fnando wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Docker image build/publish assets from stellar/stellar-cli and updates user-facing documentation to point to the dedicated Docker distribution repository (stellar/stellar-cli-docker) and Docker Hub.
Changes:
- Added a Docker run snippet and pointers to the new Docker distribution repo + Docker Hub in the main README.
- Removed the legacy Docker build recipe and entrypoint script from this repository.
- Deleted the GitHub Actions workflow that built/published Docker images and updated the Docker Hub description.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Documents how to run the CLI via Docker and links users to the new source-of-truth repo and Docker Hub. |
entrypoint.sh |
Removes the Docker entrypoint script now owned by the separate Docker distribution repo. |
Dockerfile |
Removes the Docker image build recipe from this repo to prevent drift with the new distribution repo. |
docker/README.md |
Removes the Docker Hub description content that was previously maintained here. |
.github/workflows/docker.yml |
Removes the Docker image build/publish workflow now handled elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
Dockerfile, itsentrypoint.sh, thedocker/README.md(Docker Hub description), and thedocker.ymlworkflow that built and published CLI images. Adds a note to the README's Install section pointing users to the dedicated stellar/stellar-cli-docker repository and Docker Hub.Why
Docker image building and distribution is now owned by the
stellar/stellar-cli-dockerrepository, so keeping the Dockerfile and publishing workflow here is redundant and risks the two drifting apart. Centralizing it in one place keeps the source of truth clear.Known limitations
N/A — the
ledger-emulator.ymlworkflow and thestellar containercommand still use Docker as a runtime and are unaffected; only image publishing was removed.