Add option to skip the manifest update on release - #42
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a release workflow option to republish existing CLI/Rust pairs without modifying builds.json.
Changes:
- Adds the
update_manifestworkflow input and skip-mode propagation. - Creates empty release commits and mode-specific PR descriptions.
- Adds documentation and automated tests for the new path.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/release.yml |
Adds and propagates the workflow option. |
RELEASE.md |
Documents manifest-free releases. |
scripts/release_prepare.py |
Skips manifest refresh and validation. |
scripts/release_push_branch.py |
Creates empty commits in skip mode. |
scripts/release_pr_body.py |
Generates skip-specific PR text. |
tests/integration/test_release_prepare.py |
Tests unchanged-manifest preparation. |
tests/unit/test_release_pr_body.py |
Tests skip-specific PR content. |
tests/unit/test_release_push_branch.py |
Tests empty-commit branch creation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
approved these changes
Aug 21, 2026
leighmcculloch
left a comment
Member
There was a problem hiding this comment.
Noticed a couple things, but unclear if they are significant issues worth blocking on these, so approving, but checkout the inline comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an Update manifest checkbox to the
releaseworkflow (update_manifest, default checked). When unchecked, the workflow no longer updatesbuilds.json— it skips the rust auto-pick, validation, and the "nothing changed" guard, and instead carries therelease/<tag>branch with an empty commit so the PR and downstream publish flow still fire.Why
Sometimes you want to rebuild/republish a cli's already-declared
(cli, rust)pairs — for example after a base image change that's already reflected in the pins — without adding new rust bases or otherwise changingbuilds.json. The empty-commit path gives a clean way to re-trigger the release/publish flow for the existing manifest.