Skip to content

Add option to skip the manifest update on release - #42

Merged
fnando merged 5 commits into
mainfrom
release-workflow-skip-manifest-update
Aug 21, 2026
Merged

Add option to skip the manifest update on release#42
fnando merged 5 commits into
mainfrom
release-workflow-skip-manifest-update

Conversation

@fnando

@fnando fnando commented Aug 20, 2026

Copy link
Copy Markdown
Member

What

Adds an Update manifest checkbox to the release workflow (update_manifest, default checked). When unchecked, the workflow no longer updates builds.json — it skips the rust auto-pick, validation, and the "nothing changed" guard, and instead carries the release/<tag> branch with an empty commit so the PR and downstream publish flow still fire.

Why

Sometimes you want to rebuild/republish a cli's already-declared (cli, rust) pairs — for example after a base image change that's already reflected in the pins — without adding new rust bases or otherwise changing builds.json. The empty-commit path gives a clean way to re-trigger the release/publish flow for the existing manifest.

Copilot AI balanced review requested due to automatic review settings August 20, 2026 14:06
@fnando fnando self-assigned this Aug 20, 2026
@fnando fnando added this to DevX Aug 20, 2026
@fnando fnando moved this to Needs Review in DevX Aug 20, 2026
@fnando
fnando requested review from a team and leighmcculloch August 20, 2026 14:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a release workflow option to republish existing CLI/Rust pairs without modifying builds.json.

Changes:

  • Adds the update_manifest workflow input and skip-mode propagation.
  • Creates empty release commits and mode-specific PR descriptions.
  • Adds documentation and automated tests for the new path.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
.github/workflows/release.yml Adds and propagates the workflow option.
RELEASE.md Documents manifest-free releases.
scripts/release_prepare.py Skips manifest refresh and validation.
scripts/release_push_branch.py Creates empty commits in skip mode.
scripts/release_pr_body.py Generates skip-specific PR text.
tests/integration/test_release_prepare.py Tests unchanged-manifest preparation.
tests/unit/test_release_pr_body.py Tests skip-specific PR content.
tests/unit/test_release_push_branch.py Tests empty-commit branch creation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/release_prepare.py
Comment thread scripts/release_pr_body.py
Comment thread RELEASE.md Outdated

@leighmcculloch leighmcculloch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple things, but unclear if they are significant issues worth blocking on these, so approving, but checkout the inline comments.

Comment thread scripts/release_prepare.py
Comment thread scripts/release_pr_body.py
Comment thread .github/workflows/release.yml
@fnando
fnando enabled auto-merge (squash) August 21, 2026 13:14
@fnando
fnando merged commit dac5ae7 into main Aug 21, 2026
12 checks passed
@fnando
fnando deleted the release-workflow-skip-manifest-update branch August 21, 2026 13:26
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in DevX Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants