Skip to content

[codex] Fix Claude auto fallback for MCP-only keychain#1992

Open
janpollak wants to merge 1 commit into
steipete:mainfrom
janpollak:codex/fix-claude-mcp-oauth-auto-fallback
Open

[codex] Fix Claude auto fallback for MCP-only keychain#1992
janpollak wants to merge 1 commit into
steipete:mainfrom
janpollak:codex/fix-claude-mcp-oauth-auto-fallback

Conversation

@janpollak

@janpollak janpollak commented Jul 8, 2026

Copy link
Copy Markdown
  • Skip the Claude OAuth step in Auto mode when the cached Claude CLI-owned OAuth credential is expired and the live Claude keychain only contains MCP OAuth state.
  • This avoids a doomed background refresh and lets CodexBar fall through to CLI/Web fallback, while keeping user-initiated refresh behavior unchanged.

Verification:

  • swift test --filter ClaudeOAuthFetchStrategyAvailabilityTests
  • Live UI proof from Settings...DebugFetch strategy attempts with provider Claude:
    • claude.oauth (oauth) unavailable
    • claude.cli (cli) available

The live proof shows the background Auto planner/fetch attempts falling past OAuth to the CLI fallback. The focused regression test covers the matching user-initiated path remaining available.

@clawsweeper

clawsweeper Bot commented Jul 8, 2026

Copy link
Copy Markdown

ClawSweeper review: did not complete due to Codex infrastructure failure. Reviewed July 8, 2026, 9:53 AM ET / 13:53 UTC.

Summary
Review failed before ClawSweeper could summarize the requested change.

Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path.

Review metrics: none identified.

Merge readiness
Not assessed.
Failure reason: timeout.

This is a ClawSweeper/Codex infrastructure failure, not a PR readiness or patch-quality verdict.
Keep any merge decision on the normal maintainer review path until ClawSweeper can complete a fresh review.

Risk before merge

  • [P1] No close action taken because the review did not complete.

Maintainer options:

  1. Decide the mitigation before merge
    Retry the Codex review after fixing the execution failure.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • Review did not complete, so no work-lane recommendation was made.
Review details

Best possible solution:

Retry the Codex review after fixing the execution failure.

Do we have a high-confidence way to reproduce the issue?

Unclear. The review failed before ClawSweeper could establish a reproduction path.

Is this the best way to solve the issue?

Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction.

AGENTS.md: unclear because the file could not be read completely.

Codex review notes: model internal, reasoning high; reviewed against aa401f1d8b74.

Label changes

Label changes:

  • remove P2: Current review triage priority is none.
  • remove proof: sufficient: Current real behavior proof status is not_applicable, not sufficient.
  • remove status: 👀 ready for maintainer look: Current PR status no longer selects a status label.
  • remove rating: 🐚 platinum hermit: Current review failed before PR readiness was assessed, so no rating label should remain.
  • remove merge-risk: 🚨 auth-provider: Current PR review selected no merge-risk labels.
Evidence reviewed

What I checked:

  • failure reason: timeout.
  • codex failure detail: Codex review failed for this PR: Codex process timed out after 1199999ms.
  • codex stderr: No stderr captured.
  • codex stdout: {"type":"thread.started","thread_id":"019f41ee-9a23-7f53-b793-620eceeaa339"}.
  • process error code: ETIMEDOUT.

Likely related people:

  • unknown: Codex failed before it could trace repository history. (role: review did not complete; confidence: low)
How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (3 earlier review cycles)
  • reviewed 2026-07-08T08:01:20.911Z sha c8245b1 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-08T08:07:03.524Z sha c8245b1 :: needs real behavior proof before merge. :: none
  • reviewed 2026-07-08T13:12:46.112Z sha c8245b1 :: needs maintainer review before merge. :: none

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 auth-provider 🚨 Merging this PR could break OAuth, tokens, provider routing, model choice, or credentials. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jul 8, 2026
@janpollak janpollak marked this pull request as ready for review July 8, 2026 13:31
@clawsweeper clawsweeper Bot removed proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 auth-provider 🚨 Merging this PR could break OAuth, tokens, provider routing, model choice, or credentials. P2 Normal priority bug or improvement with limited blast radius.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant