Refine Claude Team seat tier display#1965
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 7, 2026, 2:50 AM ET / 06:50 UTC. Summary Reproducibility: not applicable. for this feature PR. Source review shows the added path remains web-extras-gated; the unresolved check is live Team Standard proof, not a current-main bug reproduction. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land the gated seat-tier refinement after redacted Team Standard real-account proof confirms the display, while keeping web metadata refinement inside the existing web-extras path. Do we have a high-confidence way to reproduce the issue? Not applicable for this feature PR. Source review shows the added path remains web-extras-gated; the unresolved check is live Team Standard proof, not a current-main bug reproduction. Is this the best way to solve the issue? Yes, the current implementation is a narrow maintainable path for the label refinement. It is not merge-ready until maintainers either require or waive real Team Standard proof. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 46edb383c0ac. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (3 earlier review cycles)
|
clawsweeper
Bot
added
proof: 📸 screenshot
hegelty
force-pushed
the
agent/claude-team-seat-tier
branch
from
307ee65 to
68bbd51
Compare
clawsweeper
Bot
added
rating: 🦐 gold shrimp
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68bbd51253
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hegelty
force-pushed
the
agent/claude-team-seat-tier
branch
from
68bbd51 to
7b305b3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b305b3a6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let webText = web?.trimmingCharacters(in: .whitespacesAndNewlines) | ||
| guard let webText, !webText.isEmpty else { return current } | ||
| guard self.isGenericTeamLoginMethod(current) else { return current } | ||
| guard self.isSameAccountEmail(currentAccountEmail, webAccountEmail) else { return current } |
There was a problem hiding this comment.
Fresh evidence: this version now verifies only the email before accepting the web seat label. For a Claude user who belongs to multiple Team orgs under the same email, the web extras path can be pointed at or auto-select one organization while the primary CLI snapshot still carries another accountOrganization; this guard then accepts the web tier and the merge keeps the primary organization, producing an Org A label with a Standard/Premium tier sourced from Org B. Compare the primary/web organization as well, or skip refinement when the primary org is known and differs.
Useful? React with 👍 / 👎.
1 participant
Summary
Security/source-boundary fix
Validation
Notes
I only have access to a Claude Team Premium account. Team Standard is covered by unit tests using the observed seat_tier value, but the actual UI display should still be verified with a real Team Standard account.