Add predictive pace warnings#1960
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 9, 2026, 9:55 AM ET / 13:55 UTC. Summary Reproducibility: not applicable. as a bug reproduction: this is an implementation PR for an accepted feature request. Source inspection gives high confidence about the implemented paths, while proof sufficiency remains a PR validation gate. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land the accepted implementation after maintainers accept the proof boundary or after the PR adds redacted current-head runtime proof for the Claude OAuth no-email fallback path. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: this is an implementation PR for an accepted feature request. Source inspection gives high confidence about the implemented paths, while proof sufficiency remains a PR validation gate. Is this the best way to solve the issue? Yes for the code direction: the implementation follows the accepted default-off design and fixes the prior Claude OAuth fallback issue. Merge readiness is still gated by maintainer proof sufficiency, not by a remaining source defect. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 41331e5fb397. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (13 earlier review cycles; latest 8 shown)
|
|
Added redacted runtime proof to the PR body and marked the PR ready for review. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8c8e98edf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Added two follow-up commits after reviewing #1299, #1831, and the latest feedback:
Validation:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Updated the PR after the latest review:
Validation:
Current CI on |
|
All checks are green on @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Added fresh current-head proof to the PR body. Summary:
@clawsweeper re-review |
…ive-warnings # Conflicts: # Sources/CodexBar/UsageStore.swift
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8fbede03e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Vincent Peng <mail@vincentpeng.me>
|
Exact-head maintainer proof for
Screenshots stayed local. CI/security were checked against this exact head before merge. |
Summary
Closes #1299.
Maintainer improvements
main, including the compact quota-warning settings editor from Polish quota warning settings #1974@vincent-pengValidation
swift test --filter PredictivePaceWarningTests— 19 passedmake check— passedmake test— all 49 shards passedExact packaged/live proof
Developer-ID signed debug app on macOS 27 build 26A5368g, arm64, Xcode 26.6 / SDK 26.5:
CodexGitCommit=094233d4; deep/strict signature valid; Gatekeeper acceptede51cb36ae854ed0af5823eb22b314f8cec0dae210ad19855fe80b932ac27fbcae8fbede0produced zero warnings by default, exactly two enabled warnings (Codex Session and Weekly), and zero repeats after both reset timestamps movedThe accepted product contract is documented in
docs/superpowers/specs/2026-07-01-predictive-pace-warning-notifications-design.md.