chore: fix JavaScript lint errors (issue #14949) - #14953
Open
wofiporia wants to merge 1 commit into
Open
Conversation
Updates the stale eslint-disable-line handle-callback-err directive to the renamed rule id n/handle-callback-err in lib/node_modules/@stdlib/fs/resolve-parent-path/lib/async.js, which no longer suppresses the rule after the eslint-plugin-n migration. Resolves stdlib-js#14949. Signed-off-by: wofiporia <wofiporia@users.noreply.github.com>
Contributor
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #14949.
Description
This pull request:
eslint-disable-line handle-callback-errdirective inlib/node_modules/@stdlib/fs/resolve-parent-path/lib/async.jston/handle-callback-err. Since the migration fromeslint-plugin-nodetoeslint-plugin-n(build: replaceeslint-plugin-nodewitheslint-plugin-n(gh54 part II) #10952), the rule is registered asn/handle-callback-err, so the unprefixed directive no longer matches and the lint run reports both an unhandlederrorargument and an unused disable directive.Related Issues
This pull request has the following related issues:
Questions
No.
Other
The failure can be reproduced with eslint 8.57.0 and eslint-plugin-n 17.17.0 using
--report-unused-disable-directivesand the rule configuration frometc/eslint/rules/nodejs.js([ 'error', '^(err|error)$' ]). After updating the directive, the file lints cleanly. The change is comment-only and does not alter runtime behavior.Checklist
AI Assistance
Yes
No
Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding
Disclosure
I used AI assistance to identify the stale eslint-disable directive, confirm the rule renaming from the
eslint-plugin-nmigration, and reproduce and verify the failure locally before and after the one-line fix. I reviewed the complete diff.@stdlib-js/reviewers