Skip to content

chore: fix JavaScript lint errors (issue #14949) - #14953

Open
wofiporia wants to merge 1 commit into
stdlib-js:developfrom
wofiporia:fix-lint-14949
Open

chore: fix JavaScript lint errors (issue #14949)#14953
wofiporia wants to merge 1 commit into
stdlib-js:developfrom
wofiporia:fix-lint-14949

Conversation

@wofiporia

Copy link
Copy Markdown

Resolves #14949.

Description

This pull request:

  • Updates the stale eslint-disable-line handle-callback-err directive in lib/node_modules/@stdlib/fs/resolve-parent-path/lib/async.js to n/handle-callback-err. Since the migration from eslint-plugin-node to eslint-plugin-n (build: replace eslint-plugin-node with eslint-plugin-n (gh54 part II) #10952), the rule is registered as n/handle-callback-err, so the unprefixed directive no longer matches and the lint run reports both an unhandled error argument and an unused disable directive.

Related Issues

This pull request has the following related issues:

Questions

No.

Other

The failure can be reproduced with eslint 8.57.0 and eslint-plugin-n 17.17.0 using --report-unused-disable-directives and the rule configuration from etc/eslint/rules/nodejs.js ([ 'error', '^(err|error)$' ]). After updating the directive, the file lints cleanly. The change is comment-only and does not alter runtime behavior.

Checklist

AI Assistance

  • Yes

  • No

  • Code generation (e.g., when writing an implementation or fixing a bug)

  • Test/benchmark generation

  • Documentation (including examples)

  • Research and understanding

Disclosure

I used AI assistance to identify the stale eslint-disable directive, confirm the rule renaming from the eslint-plugin-n migration, and reproduce and verify the failure locally before and after the one-line fix. I reviewed the complete diff.


@stdlib-js/reviewers

Updates the stale eslint-disable-line handle-callback-err
directive to the renamed rule id n/handle-callback-err in
lib/node_modules/@stdlib/fs/resolve-parent-path/lib/async.js,
which no longer suppresses the rule after the eslint-plugin-n
migration.

Resolves stdlib-js#14949.

Signed-off-by: wofiporia <wofiporia@users.noreply.github.com>
@wofiporia
wofiporia requested a review from a team September 4, 2026 03:35
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Sep 4, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

2 participants