Skip to content

feat: add lapack/base/dlasrt#12354

Open
prajjwalbajpai wants to merge 2 commits into
stdlib-js:developfrom
prajjwalbajpai:dlasrt
Open

feat: add lapack/base/dlasrt#12354
prajjwalbajpai wants to merge 2 commits into
stdlib-js:developfrom
prajjwalbajpai:dlasrt

Conversation

@prajjwalbajpai
Copy link
Copy Markdown
Contributor

@prajjwalbajpai prajjwalbajpai commented May 29, 2026

Description

What is the purpose of this pull request?

This pull request:

  • adds lapack/base/dlasrt

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted ChatGPT for testcases to get 100% code coverage.

@stdlib-js/reviewers

@prajjwalbajpai
feat: add lapack/base/dlasrt
46043af 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@prajjwalbajpai prajjwalbajpai requested a review from a team May 29, 2026 16:47
@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. labels May 29, 2026
@prajjwalbajpai prajjwalbajpai added GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). and removed Needs Review A pull request which needs code review. labels May 29, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 29, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
lapack/base/dlasrt $\color{green}458/458$
$\color{green}+0.00\%$ 		$\color{green}60/60$
$\color{green}+0.00\%$ 		$\color{green}3/3$
$\color{green}+0.00\%$ 		$\color{green}458/458$
$\color{green}+0.00\%$

The above coverage report was generated for the changes in this PR.

@prajjwalbajpai prajjwalbajpai added the Needs Review A pull request which needs code review. label May 29, 2026
@prajjwalbajpai
fix: missing index update
5c26a09 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
aayush0325
aayush0325 reviewed May 30, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dlasrt/lib/dlasrt.js
return enum2str( value );
}
return null;
function dlasrt( ID, N, D ) {
Copy link
Copy Markdown
Member

@aayush0325 aayush0325 May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can let the user facing api specify increasing or decreasing instead of I and D as that is more readable, then you can pass ID[ 0 ] to the base

aayush0325
aayush0325 reviewed May 30, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/lapack/base/dlasrt/README.md

# dlasrt

> Sort an array of doubles in increasing or decreasing order using quicksort, with insertion sort for small partitions (size <= 20).
Copy link
Copy Markdown
Member

@aayush0325 aayush0325 May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Sort an array of doubles in increasing or decreasing order using quicksort, with insertion sort for small partitions (size <= 20).
> Sort an array of double-precision floating-point numbers in increasing or decreasing order using quicksort, with insertion sort for small partitions (size <= 20).

aayush0325
aayush0325 requested changes May 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same changes would apply everywhere else as well ig. you can do a careful search and replace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aayush0325 aayush0325 aayush0325 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

GSoC Google Summer of Code. gsoc: 2026 Google Summer of Code (2026). LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prajjwalbajpai @stdlib-bot @aayush0325