test: propagate annotation and REPL wrapping fixes across sibling packages#12348
Draft
Planeshifter wants to merge 3 commits into
Draft
test: propagate annotation and REPL wrapping fixes across sibling packages#12348Planeshifter wants to merge 3 commits into
Planeshifter wants to merge 3 commits into
Conversation
…tests Propagates fix from 5d3c84a ("test: fix element annotations in ndarray offset tests") to `zapx`, which shared the same misaligned `// 0` and `// 1` annotations in the offset-parameter test block. With the call `zapx( 2, alpha, x, 1, 1 )`, the iteration visits complex indices 1 and 2 (flat float positions 2-3 and 4-5), so the `// 1` markers move from flat positions 6-7 onto positions 4-5 in both the input and expected complex arrays.
Propagates fix from d69f7f9 ("docs: fix text wrapping in repl text file") to sibling REPL files whose prose paragraphs exceeded the 80-column width policy documented in docs/contributing/repl_text.md. Wraps the offending line in `utils/define-properties` while keeping `Default: undefined.` inline per the file's existing convention, and wraps the `normalize.assign` description in `number/float32/base/normalize` at the natural word boundary.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
May 29, 2026
| {{alias}}.assign( x, out, stride, offset ) | ||
| Returns a normal number `y` and exponent `exp` satisfying `x = y * 2^exp` and | ||
| assigns results to a provided output array. | ||
| Returns a normal number `y` and exponent `exp` satisfying `x = y * 2^exp` |
kgryte
reviewed
May 29, 2026
| undefined. When assigning a property value, a setter function is called with | ||
| one argument (the value being assigned to the property) and with the `this` | ||
| context set to the object through which the property is assigned. Default: undefined. | ||
| context set to the object through which the property is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-05-28 13:09 UTC and 2026-05-29 13:09 UTC to sibling packages that exhibit the same defect.test: fix element annotations in ndarray offset tests(5d3c84a): In the "supports an offset parameter" block,// 0/// 1iteration-position comments onComplex128Arraytest data were placed at flat positions 6-7 rather than 4-5, misidentifying unvisited elements as visited for a stride-1, offset-1 call over N=2 elements. The fix moves the// 1markers to the correct flat positions in bothxandexpected, aligning annotations with the actual access pattern. No behavioral change.blas/ext/base/zapxdocs: fix text wrapping in repl text file(d69f7f9): Lines inrepl.txtmust not exceed 80 columns per the wrapping policy indocs/contributing/repl_text.md. Inutils/define-propertiesthe offending line (89 chars) is wrapped before"assigned"so that"Default: undefined."remains on the same line, consistent with surrounding entries; innumber/float32/base/normalizethe 81-char line is wrapped before"and".utils/define-propertiesnumber/float32/base/normalizeRelated Issues
None.
Questions
None.
Other
Validation. Source-commit windows were enumerated with
git log --since="24 hours ago" --first-parent develop, filtered to fixes whose patterns are concretely specifiable..github/-only build commits and bot-generated regeneration commits (related-packages, namespace TOC) were excluded per the routine's generator-owned and chore filters.Candidate sites for each pattern were enumerated by structural search:
rg -l 'Complex(64|128)Array'over theblas/ext/base/*/test/test.ndarray*.jsfiles matching'supports an offset parameter', excluding the source packagecapx. Real-typed sibling tests (dapx,sapx,gapx) are immune by construction.awkwidth scan overlib/node_modules/@stdlib/**/docs/repl.txt, filtering REPL example lines (>prefix), URLs, alias placeholders, ASCII tables, and Unicode-induced byte/character mismatches (Greek letters, accented characters, en-dashes inflate byte counts but not column width).Each candidate was reviewed by two independent validation agents reading the target file in full, an adaptation agent producing the exact patch, and a style-consistency agent checking against
docs/style-guides/and sibling-file conventions. The style pass rewrote Pattern B'sutils/define-propertieswrap point so thatDefault: undefined.remains inline at the end of the paragraph, matching the convention used elsewhere in the same file and inutils/define-property/docs/repl.txt.Deliberately excluded:
blas/ext/base/*siblings (zaxpb,caxpb,cxsa,zfill,cfill,zzero-to,zone-to,czero-to,cone-to,cunitspace,zunitspace,*.native.jsof each) — annotations already correctly aligned at flat positions 2-3 and 4-5; defect not present.awkhits for over-length REPL lines — all false positives once Unicode column width is accounted for, or REPL output lines (stats/wilcoxonformatted test tables) rather than author-controlled prose.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated routine that scans recent fixes merged to
developand propagates equivalent corrections to sibling packages. Each candidate site was validated by independent automated review passes; the actual code changes are direct analogs of the human-authored source commits cited above.@stdlib-js/reviewers
Generated by Claude Code