Skip to content

test: propagate annotation and REPL wrapping fixes across sibling packages#12348

Draft
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-propagation-2026-05-29
Draft

test: propagate annotation and REPL wrapping fixes across sibling packages#12348
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-propagation-2026-05-29

Conversation

@Planeshifter
Copy link
Copy Markdown
Member

Description

Propagating fixes merged to develop between 2026-05-28 13:09 UTC and 2026-05-29 13:09 UTC to sibling packages that exhibit the same defect.

  • test: fix element annotations in ndarray offset tests (5d3c84a): In the "supports an offset parameter" block, // 0 / // 1 iteration-position comments on Complex128Array test data were placed at flat positions 6-7 rather than 4-5, misidentifying unvisited elements as visited for a stride-1, offset-1 call over N=2 elements. The fix moves the // 1 markers to the correct flat positions in both x and expected, aligning annotations with the actual access pattern. No behavioral change.

    • blas/ext/base/zapx
  • docs: fix text wrapping in repl text file (d69f7f9): Lines in repl.txt must not exceed 80 columns per the wrapping policy in docs/contributing/repl_text.md. In utils/define-properties the offending line (89 chars) is wrapped before "assigned" so that "Default: undefined." remains on the same line, consistent with surrounding entries; in number/float32/base/normalize the 81-char line is wrapped before "and".

    • utils/define-properties
    • number/float32/base/normalize

Related Issues

None.

Questions

None.

Other

Validation. Source-commit windows were enumerated with git log --since="24 hours ago" --first-parent develop, filtered to fixes whose patterns are concretely specifiable. .github/-only build commits and bot-generated regeneration commits (related-packages, namespace TOC) were excluded per the routine's generator-owned and chore filters.

Candidate sites for each pattern were enumerated by structural search:

  • Pattern A: rg -l 'Complex(64|128)Array' over the blas/ext/base/*/test/test.ndarray*.js files matching 'supports an offset parameter', excluding the source package capx. Real-typed sibling tests (dapx, sapx, gapx) are immune by construction.
  • Pattern B: awk width scan over lib/node_modules/@stdlib/**/docs/repl.txt, filtering REPL example lines ( > prefix), URLs, alias placeholders, ASCII tables, and Unicode-induced byte/character mismatches (Greek letters, accented characters, en-dashes inflate byte counts but not column width).

Each candidate was reviewed by two independent validation agents reading the target file in full, an adaptation agent producing the exact patch, and a style-consistency agent checking against docs/style-guides/ and sibling-file conventions. The style pass rewrote Pattern B's utils/define-properties wrap point so that Default: undefined. remains inline at the end of the paragraph, matching the convention used elsewhere in the same file and in utils/define-property/docs/repl.txt.

Deliberately excluded:

  • 12 complex-typed blas/ext/base/* siblings (zaxpb, caxpb, cxsa, zfill, cfill, zzero-to, zone-to, czero-to, cone-to, cunitspace, zunitspace, *.native.js of each) — annotations already correctly aligned at flat positions 2-3 and 4-5; defect not present.
  • 89 of 91 raw awk hits for over-length REPL lines — all false positives once Unicode column width is accounted for, or REPL output lines (stats/wilcoxon formatted test tables) rather than author-controlled prose.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code as part of an automated routine that scans recent fixes merged to develop and propagates equivalent corrections to sibling packages. Each candidate site was validated by independent automated review passes; the actual code changes are direct analogs of the human-authored source commits cited above.


@stdlib-js/reviewers


Generated by Claude Code

claude added 2 commits May 29, 2026 13:29
…tests

Propagates fix from 5d3c84a ("test: fix element annotations in ndarray offset tests") to `zapx`, which shared the same misaligned `// 0` and `// 1` annotations in the offset-parameter test block. With the call `zapx( 2, alpha, x, 1, 1 )`, the iteration visits complex indices 1 and 2 (flat float positions 2-3 and 4-5), so the `// 1` markers move from flat positions 6-7 onto positions 4-5 in both the input and expected complex arrays.
Propagates fix from d69f7f9 ("docs: fix text wrapping in repl text file") to sibling REPL files whose prose paragraphs exceeded the 80-column width policy documented in docs/contributing/repl_text.md. Wraps the offending line in `utils/define-properties` while keeping `Default: undefined.` inline per the file's existing convention, and wraps the `normalize.assign` description in `number/float32/base/normalize` at the natural word boundary.
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented May 29, 2026

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/zapx $\color{green}441/441$
$\color{green}+0.00\%$
$\color{green}29/29$
$\color{green}+0.00\%$
$\color{green}4/4$
$\color{green}+0.00\%$
$\color{green}441/441$
$\color{green}+0.00\%$
number/float32/base/normalize $\color{green}306/306$
$\color{green}+0.00\%$
$\color{green}14/14$
$\color{green}+0.00\%$
$\color{green}3/3$
$\color{green}+0.00\%$
$\color{green}306/306$
$\color{green}+0.00\%$
utils/define-properties $\color{green}203/203$
$\color{green}+0.00\%$
$\color{green}12/12$
$\color{green}+0.00\%$
$\color{green}1/1$
$\color{green}+0.00\%$
$\color{green}203/203$
$\color{green}+0.00\%$

The above coverage report was generated for the changes in this PR.

{{alias}}.assign( x, out, stride, offset )
Returns a normal number `y` and exponent `exp` satisfying `x = y * 2^exp` and
assigns results to a provided output array.
Returns a normal number `y` and exponent `exp` satisfying `x = y * 2^exp`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change.

undefined. When assigning a property value, a setter function is called with
one argument (the value being assigned to the property) and with the `this`
context set to the object through which the property is assigned. Default: undefined.
context set to the object through which the property is
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants