chore: propagate blas/* JSDoc and cscal header fixes to siblings#12318
Merged
Conversation
Propagates fix from 4ed822d ("docs: follow-up fixes for commits merged to `develop` on 2026-05-26") to sibling packages where a section comment incorrectly labels `require()` declarations as `VARIABLES` rather than `MODULES`.
Propagates fix from 95a8c41 ("fix: use correct argument value in error message and propagate JSDoc fixes to sibling packages") to remaining BLAS routines where `alpha` and `beta` JSDoc parameter descriptions still use `scalar` rather than `scalar constant`.
…nd `zscal` Propagates fix from 7d90009 ("fix: import `src` utility and fix description in `blas/base/cscal`") to BLAS Level 1 packages with the same defects: `caxpy_cblas.c` and `zscal_cblas.c` invoke `stdlib_strided_min_view_buffer_index()` without including `stdlib/strided/base/min_view_buffer_index.h`, and the `caxpy_cblas.h` header description still references `cblas_ccopy` instead of `cblas_caxpy`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
blas/* JSDoc and cscal header fixes to siblingsblas/* JSDoc and cscal header fixes to siblings
kgryte
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-05-26 13:11 UTC and 2026-05-27 13:11 UTC to sibling packages.blas/*scalar JSDoc descriptorsPropagates JSDoc fixes from
95a8c41a("fix: use correct argument value in error message and propagate JSDoc fixes to sibling packages") to remainingblas/*packages where@paramdescriptors foralpha,beta, and related scalar arguments still readscalarrather thanscalar constant. The fix is mechanical: every matching JSDoc line in the affected packages underblas/base,blas/base/wasm, andblas/ext/basehas the trailingscalarreplaced withscalar constantto align with the established convention.Source:
95a8c41aTarget packages:
blas/base/daxpyblas/base/dscalblas/base/gaxpyblas/base/saxpyblas/base/sscalblas/base/wasm/cscalblas/base/wasm/daxpyblas/base/wasm/dscalblas/base/wasm/saxpyblas/base/wasm/sscalblas/base/wasm/zscalblas/ext/base/sfillMissing
min_view_buffer_index.hinclude and stale header descriptionPropagates fixes from
7d900094("fix: importsrcutility and fix description inblas/base/cscal"), which corrected a missingstdlib/strided/base/min_view_buffer_index.hinclude in the cblas C source and a stalecblas_ccopyreference in the cblas header.blas/base/caxpyreceives both corrections — the missing include incaxpy_cblas.cand the wrongcblas_ccopydescription incaxpy_cblas.h;blas/base/zscalreceives only the missing include fix inzscal_cblas.c, as its header description is already correct.Source:
7d900094Target packages:
blas/base/caxpyblas/base/zscalMisclassified
VARIABLESsection headerPropagates the fix from
4ed822d3("docs: follow-up fixes for commits merged to develop on 2026-05-26"), which corrected// VARIABLES //section headers that contained onlyrequire()calls to// MODULES //. The same misclassification was present inblas/ext/base/dapx(lib/dapx.js) andndarray/find-last(lib/callback_wrapper.js), neither of which had a preceding// MODULES //section. Both headers are renamed accordingly.Source:
4ed822d3Target packages:
blas/ext/base/dapxndarray/find-lastRelated Issues
None.
Questions
No.
Other
Validation
blas/*,ndarray/*) viargand verified individually before patching.// VARIABLES //block contains onlyrequire()calls and lacks a preceding// MODULES //section; that a cblas C source actually callsstdlib_strided_min_view_buffer_index()without the corresponding header include; that the BLAS JSDoc line uses the barescalardescriptor in a@param alpha/@param betaslot).*JSDoc markers, and surrounding lines verbatim. No unrelated lines were touched.assert/*candidates for the "Return a boolean indicating" → "Boolean indicating" pattern from95a8c41a— the source fix applied to a module exporting a constant boolean, whereas the matchingsignbit/is-buffer-length-compatible*modules export functions, so the original wording is grammatically correct at those sites.@returns input array→@returns \x`from4ed822d` — too broad a scope and a stylistic convention rather than a defect; defer to a dedicated cleanup PR.fdcf93d0— site-specific and not present at sibling distribution packages.time/iso-weeks-in-yearNotes section from3b5ee6b3— single-package documentation, no clear sibling target.bernoulli/mgfisProbabilityinline refactor from3c1e93d7— adaptive and would require cross-package judgment; deferred.stats/strided/*abs"Compute" → "Calculate" descriptor refresh fromba77943b— descriptor choice is per-package and not uniformly converged acrossstats/strided/*.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of a routine fix-propagation pass over commits merged to
developin the prior 24 hours. Source commits were identified mechanically; candidate sites were enumerated byrgover a per-pattern search signature, then individually validated by reading each target file in full before patching. All patches are direct, self-contained analogs of the cited source commits.@stdlib-js/reviewers
Generated by Claude Code