docs: align parameter descriptions in blas/base/dzasum with sibling scasum#12317
Closed
Planeshifter wants to merge 1 commit into
Closed
docs: align parameter descriptions in blas/base/dzasum with sibling scasum#12317Planeshifter wants to merge 1 commit into
blas/base/dzasum with sibling scasum#12317Planeshifter wants to merge 1 commit into
Conversation
… `scasum` Use `` `x` stride length `` and `` starting index for `x` `` in JSDoc, `index increment for \`x\`.` and `starting index of \`x\`.` in the REPL docs, and `@returns out` in the TypeScript declaration to match the sibling `blas/base/scasum` package and resolve the internal `@returns sum`/`@returns out` inconsistency in `docs/types/index.d.ts`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-05-26 21:38 UTC and 2026-05-27 09:44 UTC (commitse508f182..7d900094, 15 commits).This pull request aligns parameter descriptions in the newly added
blas/base/dzasumpackage with the siblingblas/base/scasumpackage and resolves an internal inconsistency in its TypeScript declaration:blas/base/dzasum(1ff31b20):strideXwas described asstride lengthandoffsetXasstarting indexacrossREADME.md,docs/repl.txt,docs/types/index.d.ts,lib/dzasum.js, andlib/ndarray.js— the established convention acrossblas/base(216 JSDoc occurrences) is`x` stride length/starting index for `x`, withindex increment for `x`/Starting index of `x`in REPL docs. Additionally,docs/types/index.d.tsused@returns sumin theRoutineinterface but@returns outin the top-leveldeclare var; siblingscasumuses@returns outthroughout. All five files now matchscasum.Related Issues
None.
Questions
No.
Other
Validation
Checked against the per-file diffs of the 15 commits merged in the window. Each finding was independently flagged by two reviewers and cross-referenced against the sibling
blas/base/scasumpackage as well as the dominantblas/baseJSDoc/REPL conventions (grepcounts: 216 vs 2 for`x` stride lengthvsstride length; 51 vs 17 for@returns outvs@returns sum).Deliberately excluded:
lib/ndarray.jsdeclared-variable ordering (viewXvsstemp) — both identifiers are equal length, so the style guide's "descending character length" rule does not mandate one ordering over the other.No bug fixes (runtime correctness) were needed: both bug auditors returned empty result sets after tracing
dzasum's complex-stride arithmetic and thebernoulli/mgfisProbabilityrefactor against the previous semantics.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated 24-hour commit review pass. Findings were produced by four independent reviewer subagents (two style, two bug), filtered to require either multi-agent corroboration or independent re-verification against the diff, and applied without scope expansion beyond the originating commit.
Generated by Claude Code