Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion resources/js/components/assets/Editor/Editor.vue
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ import ItemActions from '@/components/actions/ItemActions.vue';
import useCheckerboard from '@/composables/checkerboard.js';

export default {
emits: ['previous', 'next', 'saved', 'closed', 'action-started', 'action-completed'],
emits: ['previous', 'next', 'saved', 'closed', 'created', 'action-started', 'action-completed'],

components: {
Button,
Expand Down Expand Up @@ -249,6 +249,10 @@ export default {
return true;
},
},
redirectAfterCrop: {
type: Boolean,
default: true,
},
},

data() {
Expand Down Expand Up @@ -448,6 +452,11 @@ export default {
},

handleCropCreated(newAssetId) {
if (!this.redirectAfterCrop) {
this.$emit('created', newAssetId);
return;
}

const [containerHandle, assetPath] = newAssetId.split('::');
const editUrl = cp_url(`assets/browse/${containerHandle}/${assetPath}/edit`);
router.get(editUrl);
Expand Down
5 changes: 5 additions & 0 deletions resources/js/components/fieldtypes/assets/Asset.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ export default {
this.closeEditor();
},

assetCreated(assetId) {
this.$emit('id-changed', this.editingId, assetId);
this.closeEditor();
},

actionCompleted(successful, response) {
if (successful === false) return;
const id = response.ids[0] || null;
Expand Down
2 changes: 2 additions & 0 deletions resources/js/components/fieldtypes/assets/AssetRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,12 @@
:id="editingId"
:allow-deleting="false"
:show-navigation="siblings.length > 1"
:redirect-after-crop="false"
@previous="navigateToPrevious"
@next="navigateToNext"
@closed="closeEditor"
@saved="assetSaved"
@created="assetCreated"
@action-completed="actionCompleted"
>
</asset-editor>
Expand Down
2 changes: 2 additions & 0 deletions resources/js/components/fieldtypes/assets/AssetTile.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@
:id="editingId"
:allow-deleting="false"
:show-navigation="siblings.length > 1"
:redirect-after-crop="false"
@previous="navigateToPrevious"
@next="navigateToNext"
@closed="closeEditor"
@saved="assetSaved"
@created="assetCreated"
@action-completed="actionCompleted"
>
</asset-editor>
Expand Down
13 changes: 13 additions & 0 deletions resources/js/tests/components/assets/Editor.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { expect, test, vi } from 'vitest';
import Editor from '@/components/assets/Editor/Editor.vue';
import Asset from '@/components/fieldtypes/assets/Asset';

function keydown(key, target, modifier) {
const component = {
Expand Down Expand Up @@ -46,3 +47,15 @@ test.each([['ctrlKey'], ['metaKey']])(
expect(keydown('ArrowRight', target, modifier).navigateToNextAsset).not.toHaveBeenCalled();
},
);

test('keeps crop copies in the asset field', () => {
const editor = { redirectAfterCrop: false, $emit: vi.fn() };
const asset = { editingId: 'assets::source.png', $emit: vi.fn(), closeEditor: vi.fn() };

Editor.methods.handleCropCreated.call(editor, 'assets::crop.png');
Asset.methods.assetCreated.call(asset, 'assets::crop.png');

expect(editor.$emit).toHaveBeenCalledWith('created', 'assets::crop.png');
expect(asset.$emit).toHaveBeenCalledWith('id-changed', 'assets::source.png', 'assets::crop.png');
expect(asset.closeEditor).toHaveBeenCalled();
});
Loading