[6.x] Fix: pagination warm failures are reported against the wrong URL

[steveparks]

The pagination pool reuses the main pass's rejection handler:

$pool = new Pool($this->client(), $requests, [
    'concurrency' => $this->concurrency(),
    'fulfilled' => function (Response $response, $index) use ($urls) {
        $this->components->twoColumnDetail($this->getRelativeUri($urls->get($index)), '<info>✓ Cached</info>');
    },
    'rejected' => [$this, 'outputFailureLine'],
]);

but outputFailureLine() resolves its URI from the compiled URI list:

public function outputFailureLine($exception, $index): void
{
    $uri = $this->getRelativeUri($this->uris()->get($index));
    ...

$index here is an index into the pagination pool — 0 for the first page being warmed, 1 for the second — not into uris(). So a failed paginated request is reported under whatever unrelated URL happens to sit at that offset in
the main list. The fulfilled handler two lines above gets this right, which is what makes the asymmetry look unintentional.

Two consequences:

• The output names a URL that did not fail, and stays silent about the one that did. That is the exact output someone reads when working out why pagination is not caching, so it actively misleads during the investigation it exists for.
• When the pagination pool has more entries than the compiled list has left at that offset, uris()->get($index) returns null and getRelativeUri(string $uri) is called with it — a deprecation on PHP 8.1+, fatal under stricter settings.

The fix — two edits

1. Let the failure line be produced for a given URL, by splitting the message formatting out of the index lookup. No behaviour change to the existing method:

2. Point the pagination pool at it, resolving the index against $urls the way fulfilled already does.

Notes

• Pure output correctness; nothing about what gets warmed changes.
• The status line is the useful part of that message — a paginated page turned away at the edge reports 403 Forbidden — which is why it is worth keeping the existing formatting rather than falling back to $exception->getMessage().

[steveparks]

I've clearly done something wrong here (worse than indentation!) — the tests pipeline seems to keep hanging

[duncanmcclean]

Don't worry about it. It's not you. GitHub Actions is having issues 😞

[steveparks]

Phew! Thanks for letting me know