Skip to content

[6.x] Fix malformed URLs with duplicate leading slashes resolving to home page #14982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 3 commits into from
Jul 13, 2026
+5 −0
Merged

[6.x] Fix malformed URLs with duplicate leading slashes resolving to home page #14982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24a0291
Fix malformed URLs with duplicate leading slashes resolving to home page
lazerg Jul 12, 2026
19860c4
Remove redundant leading-slash normalization in Path::tidy()
jasonvarga Jul 13, 2026
907c4c6
Move duplicate-leading-slash test cases to UrlTest's relativeProvider
jasonvarga Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Facades/Endpoint/URL.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ public function removeSiteUrl(?string $url): string
*/
public function makeRelative(?string $url): string
{
// Normalize duplicate leading slashes before parsing to avoid protocol-relative URL interpretation.
$url = preg_replace('#^/+#', '/', (string) $url);

$parsed = parse_url($url);

$url = $parsed['path'] ?? '/';
Expand Down
2 changes: 2 additions & 0 deletions tests/Facades/UrlTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,8 @@ public static function relativeProvider()
'already relative nested route without trailing slash' => ['/foo/page', '/foo/page'],
'already relative nested route with trailing slash' => ['/foo/page/', '/foo/page'],
'already relative nested route without leading slash' => ['foo/page', '/foo/page'],
'duplicate leading slashes' => ['//page', '/page'],
'multiple duplicate leading slashes' => ['////page', '/page'],

'homepage without trailing slash and query param' => ['http://example.com?bar=baz', '/?bar=baz'],
'homepage with trailing slash and query param' => ['http://example.com/?bar=baz', '/?bar=baz'],
Expand Down
Loading