Skip to content

Fix failing pkgdown - #1242

Open
VisruthSK wants to merge 4 commits into
masterfrom
fix-pkgdown-fail
Open

Fix failing pkgdown#1242
VisruthSK wants to merge 4 commits into
masterfrom
fix-pkgdown-fail

Conversation

@VisruthSK

@VisruthSK VisruthSK commented Jul 30, 2026

Copy link
Copy Markdown
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Fixes failing pkgdown GHA. Closes #1241. This is a temporary fix though and won't be needed when either package has a version bump/when their binaries are rebuilt for any reason.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Visruth Srimath Kandali

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.71%. Comparing base (2989b3e) to head (5886f9a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
- Coverage   91.73%   91.71%   -0.02%     
==========================================
  Files          15       15              
  Lines        6277     6277              
==========================================
- Hits         5758     5757       -1     
- Misses        519      520       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@VisruthSK VisruthSK changed the title Force source install of stringfish Fix failing pkgdown Aug 2, 2026
@VisruthSK

VisruthSK commented Aug 2, 2026

Copy link
Copy Markdown
Member Author

@VisruthSK
VisruthSK marked this pull request as ready for review August 2, 2026 20:05
@VisruthSK
VisruthSK requested a review from jgabry August 2, 2026 20:05

@jgabry jgabry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Should we keep this (or a different) issue open to remember to remove this special handling eventually?

@VisruthSK

Copy link
Copy Markdown
Member Author

Yes, maybe keeping the same issue open and modifying it is good enough though, less churn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkgdown workflow consistently fails due to failure to build dependency

3 participants