For laplace, don't overwrite optimize CSV when mode=NULL and output_basename is specified #1191
Open
jgabry wants to merge 2 commits into
Open
For laplace, don't overwrite optimize CSV when mode=NULL and output_basename is specified #1191jgabry wants to merge 2 commits into
mode=NULL and output_basename is specified #1191jgabry wants to merge 2 commits into
Conversation
…t_basename` is specified
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1191 +/- ##
=======================================
Coverage 90.44% 90.44%
=======================================
Files 15 15
Lines 6124 6125 +1
=======================================
+ Hits 5539 5540 +1
Misses 585 585 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
For the laplace method, in the specific case where
mode=NULLandoutput_basenameis specified, the CSV written byoptimizecould be overwritten. This gives it a unique name (addingmodeto the name) so it can't be overwritten.Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: