Skip to content

For laplace, don't overwrite optimize CSV when mode=NULL and output_basename is specified #1191

Open
jgabry wants to merge 2 commits into
masterfrom
bugfix/laplace-output-basename-conflict
Open

For laplace, don't overwrite optimize CSV when mode=NULL and output_basename is specified #1191
jgabry wants to merge 2 commits into
masterfrom
bugfix/laplace-output-basename-conflict

Conversation

@jgabry
Copy link
Copy Markdown
Member

@jgabry jgabry commented Jun 3, 2026

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

For the laplace method, in the specific case where mode=NULL and output_basename is specified, the CSV written by optimize could be overwritten. This gives it a unique name (adding mode to the name) so it can't be overwritten.

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.44%. Comparing base (ddf749b) to head (4baab8c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files          15       15           
  Lines        6124     6125    +1     
=======================================
+ Hits         5539     5540    +1     
  Misses        585      585           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants