Skip to content

$lp_approx(), $mle() should return numeric vectors regardless of default draws format #1190

Merged
jgabry merged 1 commit into
masterfrom
bugfix/fit-helper-draws-format
Jun 3, 2026
Merged

$lp_approx(), $mle() should return numeric vectors regardless of default draws format #1190
jgabry merged 1 commit into
masterfrom
bugfix/fit-helper-draws-format

Conversation

@jgabry
Copy link
Copy Markdown
Member

@jgabry jgabry commented Jun 3, 2026

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

Ensure that $lp_approx() and $mle() methods return numeric vectors regardless of default draws format

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.24%. Comparing base (5576fd7) to head (897f6fe).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   91.21%   91.24%   +0.03%     
==========================================
  Files          15       15              
  Lines        6125     6124       -1     
==========================================
+ Hits         5587     5588       +1     
+ Misses        538      536       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry jgabry merged commit ddf749b into master Jun 3, 2026
14 checks passed
@jgabry jgabry deleted the bugfix/fit-helper-draws-format branch June 3, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants